Commit Graph

15 Commits

Author SHA1 Message Date
John Crispin
81d9f2d585 scripts: fix wrong usage of '==' operator
[base-files] shell-scripting: fix wrong usage of '==' operator

normally the '==' is used for invoking a regex parser and is a bashism.
all of the fixes just want to compare a string. the used busybox-ash
will silently "ignore" this mistake, but make it portable/clean at least.

this patch does not change the behavior/logic of the scripts.

Signed-off-by: Bastian Bittorf <bittorf@bluebottle.com>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@42911 3c298f89-4303-0410-b956-a3cf2f4a3e73
2014-10-14 12:21:11 +00:00
Steven Barth
143de7849f dropbear: ensure the interface has an ip-address
Use network_get_ipaddrs_all to get all ip-addresses of an interface. If the
function fails, the interface does not exists or has not any suiteable ip
addresses assigned.

Use the returned ip-address(es) to construct the dropbear listen address.

Signed-off-by: Mathias Kresin <openwrt@kresin.me>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@42857 3c298f89-4303-0410-b956-a3cf2f4a3e73
2014-10-09 07:16:35 +00:00
John Crispin
23bf27fad7 dropbear: add mdns support to the init.d script
Signed-off-by: John Crispin <blogic@openwrt.org>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@42326 3c298f89-4303-0410-b956-a3cf2f4a3e73
2014-08-29 18:16:41 +00:00
John Crispin
e723b7928a package/*: remove useless explicit set of function returncode
somebody started to set a function returncode in the validation
stuff and everybody copies it, e.g.

myfunction()
{
	fire_command

	return $?
}

a function automatically returns with the last returncode,
so we can safely remove the command 'return $?'. reference:

http://tldp.org/LDP/abs/html/exit-status.html
"The last command executed in the function or script determines the exit status."

Signed-off-by: Bastian Bittorf <bittorf@bluebottle.com>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@42278 3c298f89-4303-0410-b956-a3cf2f4a3e73
2014-08-25 06:35:50 +00:00
John Crispin
3b660e4079 dropbear: make missing variables local
Signed-off-by: Reiner Herrmann <reiner@reiner-h.de>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@40914 3c298f89-4303-0410-b956-a3cf2f4a3e73
2014-06-02 12:43:16 +00:00
Felix Fietkau
31c24e7253 dropbear: add options SSHKeepAlive and IdleTimeout.
Without timeout mechanism, if ssh client disconnected without sending
FIN or RST, forked dropbear servers would hang there for
KEX_RETRY_TIMEOUT seconds (8 hours).

TCP keepalive is not implemented in dropbear yet, thus the name
SSHKeepAlive.

300 seconds in this patch is selected from the default value of
ServerAliveInterval for Debian ssh client (See man ssh_config).

Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@40299 3c298f89-4303-0410-b956-a3cf2f4a3e73
2014-03-29 17:05:35 +00:00
Felix Fietkau
49be87f44e dropbear: fix interface config setting
Patch from #15070

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@40298 3c298f89-4303-0410-b956-a3cf2f4a3e73
2014-03-29 16:59:33 +00:00
John Crispin
fdb2563eb3 procd: fixup 2 wrong option types
Signed-off-by: John Crispin <blogic@openwrt.org>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@38789 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-11-13 11:07:24 +00:00
John Crispin
a79f9a758e procd: convert services to the new validation api
Signed-off-by: John Crispin <blogic@openwrt.org>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@38787 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-11-13 10:49:41 +00:00
Luka Perkov
cebf051302 [package] fix various init scripts
Changes include:

* removing unused variables
* replacing spaces with tabs where appropriate
* more consistency with variable declarations

Signed-off-by: Luka Perkov <luka@openwrt.org>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@38142 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-09-23 21:58:36 +00:00
John Crispin
d330d9fac4 procd: convert various packages to procd style init.d scripts
Signed-off-by: John Crispin <blogic@openwrt.org>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@38023 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-09-17 21:45:30 +00:00
John Crispin
9af7d06947 dropbear: register a config.change trigger
Signed-off-by: John Crispin <blogic@openwrt.org>

git-svn-id: svn://svn.openwrt.org/openwrt/trunk@37245 3c298f89-4303-0410-b956-a3cf2f4a3e73
2013-07-11 17:00:40 +00:00
Felix Fietkau
dd07d18592 dropbear: convert init script to procd
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@34867 3c298f89-4303-0410-b956-a3cf2f4a3e73
2012-12-22 18:56:13 +00:00
Felix Fietkau
eca53dd739 dropbear: use network_get_device instead of scan_interfaces to get the device name
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@34863 3c298f89-4303-0410-b956-a3cf2f4a3e73
2012-12-22 18:55:57 +00:00
Felix Fietkau
abe70b1494 packages: sort network related packages into package/network/
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@33688 3c298f89-4303-0410-b956-a3cf2f4a3e73
2012-10-10 12:32:29 +00:00