This fixes regression introduced in my recent ledtrig-netdev commit.
Events triggered by different interfaces were stopping timer so it
wasn't working for tx/rx mode.
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Backport of r48072
git-svn-id: svn://svn.openwrt.org/openwrt/branches/chaos_calmer@48074 3c298f89-4303-0410-b956-a3cf2f4a3e73
The ppp0 interface is renamed after the connection is established. Due
to a missing NETDEV_REGISTER event, the ledtrig-netdev isn't aware of
the renamed interface and literally ignores the device
(no tx/rx indication, led isn't switched off with 'ifdown wan').
Signed-off-by: Mathias Kresin <openwrt@kresin.me>
Backport of r48048
git-svn-id: svn://svn.openwrt.org/openwrt/branches/chaos_calmer@48073 3c298f89-4303-0410-b956-a3cf2f4a3e73
Previously switching to non-existing device (interface) could result in
leaving LED on.
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Backport of r47990
git-svn-id: svn://svn.openwrt.org/openwrt/branches/chaos_calmer@47992 3c298f89-4303-0410-b956-a3cf2f4a3e73
We may just delete timer on every trigger update and then start it again
if needed. This will let us avoid both: races and locking in frequently
called timer callback.
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Backport of r47987
git-svn-id: svn://svn.openwrt.org/openwrt/branches/chaos_calmer@47991 3c298f89-4303-0410-b956-a3cf2f4a3e73
Read/write lock was adding useless complexity, there wasn't any real
gain in case of this driver.
Also switch to _bh variants to avoid deadlocks.
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Backport of r47986
git-svn-id: svn://svn.openwrt.org/openwrt/branches/chaos_calmer@47989 3c298f89-4303-0410-b956-a3cf2f4a3e73
All supported kernels require patching ledtrig-netdev in the same way,
so it's safe to just move these changes to the base version of this
driver. We needed these patches for some old kernels 2.6.36 and 3.11.
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Backport of r47962
git-svn-id: svn://svn.openwrt.org/openwrt/branches/chaos_calmer@47988 3c298f89-4303-0410-b956-a3cf2f4a3e73