From 8e55051410e0396b6d3dafa77b4a1ca4269c73e0 Mon Sep 17 00:00:00 2001
From: Pax1601 <d.passoni92@gmail.com>
Date: Tue, 25 Mar 2025 09:58:37 +0100
Subject: [PATCH] fix: Unit targets not being shown

---
 frontend/react/src/constants/constants.ts    |  2 +-
 frontend/react/src/ui/panels/optionsmenu.tsx | 11 +++++++++++
 frontend/react/src/unit/unit.ts              |  2 +-
 3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/frontend/react/src/constants/constants.ts b/frontend/react/src/constants/constants.ts
index cce7171a..7e6675c8 100644
--- a/frontend/react/src/constants/constants.ts
+++ b/frontend/react/src/constants/constants.ts
@@ -402,7 +402,7 @@ export const MAP_OPTIONS_DEFAULTS: MapOptions = {
   hideUnitsShortRangeRings: true,
   showUnitContacts: true,
   showUnitPaths: true,
-  showUnitTargets: false,
+  showUnitTargets: true,
   showUnitLabels: true,
   showUnitsEngagementRings: true,
   showUnitsAcquisitionRings: true,
diff --git a/frontend/react/src/ui/panels/optionsmenu.tsx b/frontend/react/src/ui/panels/optionsmenu.tsx
index f33f11ab..fdc732f1 100644
--- a/frontend/react/src/ui/panels/optionsmenu.tsx
+++ b/frontend/react/src/ui/panels/optionsmenu.tsx
@@ -155,6 +155,17 @@ export function OptionsMenu(props: { open: boolean; onClose: () => void; childre
             <OlCheckbox checked={mapOptions.showUnitTargets} onChange={() => {}}></OlCheckbox>
             <span className="my-auto">Show detection lines</span>
           </div>
+          <div
+            className={`
+              group flex cursor-pointer flex-row content-center justify-start
+              gap-4 rounded-md p-2
+              dark:hover:bg-olympus-400
+            `}
+            onClick={() => getApp().getMap().setOption("showUnitTargets", !mapOptions.showUnitTargets)}
+          >
+            <OlCheckbox checked={mapOptions.showUnitTargets} onChange={() => {}}></OlCheckbox>
+            <span className="my-auto">Show unit targets</span>
+          </div>
           <div
             className={`
               group flex cursor-pointer flex-row content-center justify-start
diff --git a/frontend/react/src/unit/unit.ts b/frontend/react/src/unit/unit.ts
index b532bc68..3db03298 100644
--- a/frontend/react/src/unit/unit.ts
+++ b/frontend/react/src/unit/unit.ts
@@ -2355,7 +2355,7 @@ export abstract class Unit extends CustomMarker {
   }
 
   #drawTarget() {
-    if (this.#targetPosition.lat != 0 && this.#targetPosition.lng != 0 && getApp().getMap().getOptions().showUnitPaths) {
+    if (this.#targetPosition.lat != 0 && this.#targetPosition.lng != 0 && getApp().getMap().getOptions().showUnitTargets) {
       this.#drawTargetPosition(this.#targetPosition);
     } else if (this.#targetID != 0 && getApp().getMap().getOptions().showUnitTargets) {
       const target = getApp().getUnitsManager().getUnitByID(this.#targetID);