weyne/DCS_MissionDev
1
0
Fork 0
mirror of https://github.com/iTracerFacer/DCS_MissionDev.git synced 2025-12-03 04:14:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added a guarded _safeRemoveMenu helper in Moose_CTLD_FAC.lua, so menu cleanup now verifies registration and logs stale handles instead of triggering BASE menu errors.

Browse Source 
Introduced a safeCoordinate utility and threaded it through the stuck-aircraft monitor, RTB routing, and interceptor launch flow in Moose_TADC_Load2nd.lua, wrapping all coordinate math/tasking calls with pcall and emitting clear diagnostics when data vanishes mid-mission.
Normalized interceptor name/coordinate tracking to reuse the same safely-fetched identifiers, preventing future nil dereferences when RTB or cleanup runs after units despawn.
This commit is contained in:
iTracerFacer
2025-11-15 02:04:01 -06:00
parent dddd39407a
commit 88c159d52a
3 changed files with 145 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
Moose_CTLD_Pure/Moose_CTLD_FAC.lua
View File

@@ -454,13 +454,44 @@ end
-- #endregion Event wiring
-- #region Housekeeping
function FAC:_safeRemoveMenu(menu, reason)
if not menu or type(menu) ~= 'table' then return end
local shouldRemove = true
if MENU_INDEX and menu.Group and menu.MenuText then
local okPath, path = pcall(function()
return MENU_INDEX:ParentPath(menu.ParentMenu, menu.MenuText)
end)
if okPath and path then
local okHas, registered = pcall(function()
return MENU_INDEX:HasGroupMenu(menu.Group, path)
end)
if not okHas or registered ~= menu then
shouldRemove = false
end
else
shouldRemove = false
end
end
if shouldRemove and menu.Remove then
local ok, err = pcall(function() menu:Remove() end)
if not ok and err then
_log(self, LOG_VERBOSE, string.format('Failed removing menu (%s): %s', tostring(reason or menu.MenuText or 'unknown'), tostring(err)))
end
elseif not shouldRemove then
_log(self, LOG_DEBUG, string.format('Skip stale menu removal (%s)', tostring(reason or menu.MenuText or 'unknown')))
end
if menu.Destroy then pcall(function() menu:Destroy() end) end
if menu.Delete then pcall(function() menu:Delete() end) end
end
function FAC:_cleanupMenuForGroup(gname)
local menuSet = self._menus[gname]
if not menuSet then return end
for _,menu in pairs(menuSet) do
if menu and menu.Remove then
pcall(function() menu:Remove() end)
end
self:_safeRemoveMenu(menu, gname)
end
self._menus[gname] = nil
self._menuLastSeen[gname] = nil