From 900cf0a9d0eacdfd6d8fef1c1a07bd7f0e756000 Mon Sep 17 00:00:00 2001
From: Khopa <clemguip@gmail.com>
Date: Thu, 31 Dec 2020 13:16:09 +0100
Subject: [PATCH 1/3] Update preview version number

---
 game/version.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/game/version.py b/game/version.py
index 0a4d2acb..c09b6e15 100644
--- a/game/version.py
+++ b/game/version.py
@@ -2,7 +2,7 @@ from pathlib import Path
 
 
 def _build_version_string() -> str:
-    components = ["2.3.3"]
+    components = ["2.3.4"]
     build_number_path = Path("resources/buildnumber")
     if build_number_path.exists():
         with build_number_path.open("r") as build_number_file:

From e3bd9580699948f637ed8a5eb683af05fefa228a Mon Sep 17 00:00:00 2001
From: Khopa <clemguip@gmail.com>
Date: Thu, 31 Dec 2020 13:28:21 +0100
Subject: [PATCH 2/3] Fixed possible AttributeError when generating missile
 site fire tasks

---
 gen/groundobjectsgen.py | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/gen/groundobjectsgen.py b/gen/groundobjectsgen.py
index 57a5544e..672f7c1d 100644
--- a/gen/groundobjectsgen.py
+++ b/gen/groundobjectsgen.py
@@ -121,12 +121,15 @@ class MissileSiteGenerator(GenericGroundObjectGenerator):
         # TODO : Add delay to task to spread fire task over mission duration ?
         for group in self.ground_object.groups:
             vg = self.m.find_group(group.name)
-            targets = self.possible_missile_targets(vg)
-            if vg is not None and targets:
-                target = random.choice(targets)
-                real_target = target.point_from_heading(random.randint(0, 360), random.randint(0, 2500))
-                vg.points[0].add_task(FireAtPoint(real_target))
-                logging.info("Set up fire task for missile group.")
+            if vg is not None:
+                targets = self.possible_missile_targets(vg)
+                if targets:
+                    target = random.choice(targets)
+                    real_target = target.point_from_heading(random.randint(0, 360), random.randint(0, 2500))
+                    vg.points[0].add_task(FireAtPoint(real_target))
+                    logging.info("Set up fire task for missile group.")
+                else:
+                    logging.info("Couldn't setup missile site to fire, no valid target in range.")
             else:
                 logging.info("Couldn't setup missile site to fire, group was not generated.")
 

From 4a483c3b2796d2e01061115679e90a9e2a7d9b8b Mon Sep 17 00:00:00 2001
From: Khopa <clemguip@gmail.com>
Date: Thu, 31 Dec 2020 13:52:02 +0100
Subject: [PATCH 3/3] Changelog

---
 changelog.md | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/changelog.md b/changelog.md
index 616f2aab..1d45037d 100644
--- a/changelog.md
+++ b/changelog.md
@@ -1,3 +1,8 @@
+# 2.3.4
+
+## Fixes:
+* **[Mission Generator]** Mission generator would crash when generating fire missions for destroyed SCUD sites - fixed
+
 # 2.3.3
 
 ## Features/Improvements