Wrap the pydcs FlyingType in our own AircraftType.

This is an attempt to remove a lot of our supposedly unnecessary error
handling. Every aircraft should have a price, a description, a name,
etc; and none of those should require carrying around the faction's
country as context.

This moves all the data for aircraft into yaml files (only one converted
here as an example). Most of the "extended unit info" isn't actually
being read yet.

To replace the renaming of units based on the county, we instead
generate multiple types of each unit when necessary. The CF-18 is just
as much a first-class type as the F/A-18 is.

This doesn't work in its current state because it does break all the
existing names for aircraft that are used in the faction and squadron
files, and we no longer let those errors go as a warning. It will be an
annoying one time switch, but it allows us to define the names that get
used in these files instead of being sensitive to changes as they happen
in pydcs, and allows faction designers to specifically choose, for
example, the Su-22 instead of the Su-17.

One thing not handled by this is aircraft task capability. This is
because the lists in ai_flight_planner_db.py are a priority list, and to
move it out to a yaml file we'd need to assign a weight to it that would
be used to stack rank each aircraft. That's doable, but it makes it much
more difficult to see the ordering of aircraft at a glance, and much
more annoying to move aircraft around in the priority list. I don't
think this is worth doing, and the priority lists will remain in their
own separate lists.

This includes the converted I used to convert all the old unit info and
factions to the new format. This doesn't need to live long, but we may
want to reuse it in the future so we want it in the version history.

game/squadrons.py

@@ -8,7 +8,6 @@ from dataclasses import dataclass, field
 from enum import unique, Enum
 from pathlib import Path
 from typing import (
-    Type,
     Tuple,
     TYPE_CHECKING,
     Optional,
@@ -17,10 +16,9 @@ from typing import (
 )
 
 import yaml
-from dcs.unittype import FlyingType
 from faker import Faker
 
-from game.db import flying_type_from_name
+from game.dcs.aircrafttype import AircraftType
 from game.settings import AutoAtoBehavior
 
 if TYPE_CHECKING:
@@ -79,7 +77,7 @@ class Squadron:
     nickname: str
     country: str
     role: str
-    aircraft: Type[FlyingType]
+    aircraft: AircraftType
     livery: Optional[str]
     mission_types: tuple[FlightType, ...]
     pilots: list[Pilot]
@@ -196,9 +194,11 @@ class Squadron:
         with path.open() as squadron_file:
             data = yaml.safe_load(squadron_file)
 
-        unit_type = flying_type_from_name(data["aircraft"])
-        if unit_type is None:
-            raise KeyError(f"Could not find any aircraft with the ID {unit_type}")
+        name = data["aircraft"]
+        try:
+            unit_type = AircraftType.named(name)
+        except KeyError as ex:
+            raise KeyError(f"Could not find any aircraft named {name}") from ex
 
         pilots = [Pilot(n, player=False) for n in data.get("pilots", [])]
         pilots.extend([Pilot(n, player=True) for n in data.get("players", [])])
@@ -245,8 +245,8 @@ class SquadronLoader:
         yield Path(persistency.base_path()) / "Liberation/Squadrons"
         yield Path("resources/squadrons")
 
-    def load(self) -> dict[Type[FlyingType], list[Squadron]]:
-        squadrons: dict[Type[FlyingType], list[Squadron]] = defaultdict(list)
+    def load(self) -> dict[AircraftType, list[Squadron]]:
+        squadrons: dict[AircraftType, list[Squadron]] = defaultdict(list)
         country = self.game.country_for(self.player)
         faction = self.game.faction_for(self.player)
         any_country = country.startswith("Combined Joint Task Forces ")
@@ -317,7 +317,7 @@ class AirWing:
                 )
             ]
 
-    def squadrons_for(self, aircraft: Type[FlyingType]) -> Sequence[Squadron]:
+    def squadrons_for(self, aircraft: AircraftType) -> Sequence[Squadron]:
         return self.squadrons[aircraft]
 
     def squadrons_for_task(self, task: FlightType) -> Iterator[Squadron]:
@@ -325,7 +325,7 @@ class AirWing:
             if task in squadron.mission_types:
                 yield squadron
 
-    def squadron_for(self, aircraft: Type[FlyingType]) -> Squadron:
+    def squadron_for(self, aircraft: AircraftType) -> Squadron:
         return self.squadrons_for(aircraft)[0]
 
     def iter_squadrons(self) -> Iterator[Squadron]: