asset reference links 😎 (#1363)

Adds urls to unit info pages that don't have data.
This commit is contained in:
Chris Seagraves 2021-06-30 14:04:06 -05:00 committed by GitHub
parent d99f8fef09
commit 5f5b5f69e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 14 additions and 2 deletions

View File

@ -12,6 +12,8 @@ Saves from 4.0.0 are compatible with 4.0.1.
## Features/Improvements
* **[UI]** Google search link added to unit information when there is no information provided.
## Fixes
# 4.0.0

View File

@ -229,7 +229,10 @@ class AircraftType(UnitType[FlyingType]):
yield AircraftType(
dcs_unit_type=aircraft,
name=variant,
description=data.get("description", "No data."),
description=data.get(
"description",
f"No data. <a href=\"https://google.com/search?q=DCS+{variant.replace(' ', '+')}\"><span style=\"color:#FFFFFF\">Google {variant}</span></a>",
),
year_introduced=introduction,
country_of_origin=data.get("origin", "No data."),
manufacturer=data.get("manufacturer", "No data."),

View File

@ -57,6 +57,7 @@ class GroundUnitType(UnitType[VehicleType]):
def _load_all(cls) -> None:
for unit_type in cls._each_unit_type():
for data in cls._each_variant_of(unit_type):
print(data.name, data.description)
cls.register(data)
cls._loaded = True
@ -88,7 +89,10 @@ class GroundUnitType(UnitType[VehicleType]):
unit_class=unit_class,
spawn_weight=data.get("spawn_weight", 0),
name=variant,
description=data.get("description", "No data."),
description=data.get(
"description",
f"No data. <a href=\"https://google.com/search?q=DCS+{variant.replace(' ', '+')}\"><span style=\"color:#FFFFFF\">Google {variant}</span></a>",
),
year_introduced=introduction,
country_of_origin=data.get("origin", "No data."),
manufacturer=data.get("manufacturer", "No data."),

View File

@ -94,6 +94,9 @@ class QUnitInfoWindow(QDialog):
self.details_text = QTextBrowser()
self.details_text.setProperty("style", "info-desc")
self.details_text.setText(unit_type.description)
self.details_text.setOpenExternalLinks(
True
) # in aircrafttype.py and groundunittype.py, for the descriptions, if No Data. including a google search link
self.gridLayout.addWidget(self.details_text, 3, 0)
self.layout.addLayout(self.gridLayout, 1, 0)