From 6bfb8cf2fde43880692c6b7b7a54147dd2d83a7b Mon Sep 17 00:00:00 2001 From: Dan Albert Date: Tue, 6 Oct 2020 23:31:40 -0700 Subject: [PATCH] Fix double logging. Calling logging.basicConfig creates a stream handler for the root logger, and then we were adding our own with a different formatter. Pass the format string to basicConfig so we don't need to add our own duplicate stream handler. --- qt_ui/logging_config.py | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/qt_ui/logging_config.py b/qt_ui/logging_config.py index 5febea7d..739e8ac0 100644 --- a/qt_ui/logging_config.py +++ b/qt_ui/logging_config.py @@ -1,26 +1,22 @@ +"""Logging APIs.""" import logging import os from logging.handlers import RotatingFileHandler -def init_logging(version_string): +def init_logging(version: str) -> None: + """Initializes the logging configuration.""" if not os.path.isdir("./logs"): os.mkdir("logs") - logging.basicConfig(level="DEBUG") + fmt = "%(asctime)s :: %(levelname)s :: %(message)s" + logging.basicConfig(level=logging.DEBUG, format=fmt) logger = logging.getLogger() - formatter = logging.Formatter('%(asctime)s :: %(levelname)s :: %(message)s') - handler = RotatingFileHandler('./logs/liberation.log', 'a', 5000000, 1) handler.setLevel(logging.INFO) - handler.setFormatter(formatter) + handler.setFormatter(logging.Formatter(fmt)) - stream_handler = logging.StreamHandler() - stream_handler.setLevel(logging.DEBUG) - stream_handler.setFormatter(formatter) - - logger.addHandler(stream_handler) logger.addHandler(handler) - logger.info("DCS Liberation {}".format(version_string)) + logger.info(f"DCS Liberation {version}")