Move mission type compatibility to the target.

This was also needed in other parts of the UI and is easier to implement
in the target class anyway.

Note that DEAD is now properly restricted to air defense targets.

Also added error boxes to the UI for when planning fails on an invalid
target.

theater/__init__.py

@@ -2,3 +2,4 @@ from .base import *
 from .conflicttheater import *
 from .controlpoint import *
 from .missiontarget import MissionTarget
+from .theatergroundobject import SamGroundObject

theater/conflicttheater.py

@@ -18,6 +18,7 @@ from dcs.terrain import (
 )
 from dcs.terrain.terrain import Terrain
 
+from gen.flights.flight import FlightType
 from .controlpoint import ControlPoint, MissionTarget
 from .landmap import Landmap, load_landmap, poly_contains
 
@@ -354,6 +355,14 @@ class FrontLine(MissionTarget):
         """Returns True if the objective is in friendly territory."""
         return False
 
+    def mission_types(self, for_player: bool) -> Iterator[FlightType]:
+        yield from [
+            FlightType.CAS,
+            # TODO: FlightType.TROOP_TRANSPORT
+            # TODO: FlightType.EVAC
+        ]
+        yield from super().mission_types(for_player)
+
     @property
     def position(self):
         """

theater/controlpoint.py

@@ -2,8 +2,8 @@ from __future__ import annotations
 
 import itertools
 import re
-from typing import Dict, List, TYPE_CHECKING
 from enum import Enum
+from typing import Dict, Iterator, List, TYPE_CHECKING
 
 from dcs.mapping import Point
 from dcs.ships import (
@@ -20,12 +20,12 @@ from .base import Base
 from .missiontarget import MissionTarget
 from .theatergroundobject import (
     BaseDefenseGroundObject,
-    SamGroundObject,
     TheaterGroundObject,
 )
 
 if TYPE_CHECKING:
     from game import Game
+    from gen.flights.flight import FlightType
 
 
 class ControlPointType(Enum):
@@ -237,3 +237,28 @@ class ControlPoint(MissionTarget):
         from .start_generator import BaseDefenseGenerator
         self.base_defenses = []
         BaseDefenseGenerator(game, self).generate()
+
+    def mission_types(self, for_player: bool) -> Iterator[FlightType]:
+        yield from super().mission_types(for_player)
+        if self.is_friendly(for_player):
+            if self.is_fleet:
+                yield from [
+                    # TODO: FlightType.INTERCEPTION
+                    # TODO: Buddy tanking for the A-4?
+                    # TODO: Rescue chopper?
+                    # TODO: Inter-ship logistics?
+                ]
+            else:
+                yield from [
+                    # TODO: FlightType.INTERCEPTION
+                    # TODO: FlightType.LOGISTICS
+                ]
+        else:
+            if self.is_fleet:
+                yield from [
+                    # TODO: FlightType.ANTISHIP
+                ]
+            else:
+                yield from [
+                    # TODO: FlightType.STRIKE
+                ]

theater/missiontarget.py

@@ -1,7 +1,12 @@
 from __future__ import annotations
 
+from typing import Iterator, TYPE_CHECKING
+
 from dcs.mapping import Point
 
+if TYPE_CHECKING:
+    from gen.flights.flight import FlightType
+
 
 class MissionTarget:
     def __init__(self, name: str, position: Point) -> None:
@@ -21,3 +26,18 @@ class MissionTarget:
     def is_friendly(self, to_player: bool) -> bool:
         """Returns True if the objective is in friendly territory."""
         raise NotImplementedError
+
+    def mission_types(self, for_player: bool) -> Iterator[FlightType]:
+        from gen.flights.flight import FlightType
+        if self.is_friendly(for_player):
+            yield FlightType.BARCAP
+        else:
+            yield from [
+                FlightType.ESCORT,
+                FlightType.TARCAP,
+                FlightType.SEAD,
+                FlightType.SWEEP,
+                # TODO: FlightType.ELINT,
+                # TODO: FlightType.EWAR,
+                # TODO: FlightType.RECON,
+            ]

theater/theatergroundobject.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 import itertools
-from typing import List, TYPE_CHECKING
+from typing import Iterator, List, TYPE_CHECKING
 
 from dcs.mapping import Point
 from dcs.unit import Unit
@@ -9,6 +9,8 @@ from dcs.unitgroup import Group
 
 if TYPE_CHECKING:
     from .controlpoint import ControlPoint
+    from gen.flights.flight import FlightType
+
 from .missiontarget import MissionTarget
 
 NAME_BY_CATEGORY = {
@@ -114,7 +116,18 @@ class TheaterGroundObject(MissionTarget):
         return "BLUE" if self.control_point.captured else "RED"
 
     def is_friendly(self, to_player: bool) -> bool:
-        return not self.control_point.is_friendly(to_player)
+        return self.control_point.is_friendly(to_player)
+
+    def mission_types(self, for_player: bool) -> Iterator[FlightType]:
+        from gen.flights.flight import FlightType
+        if self.is_friendly(for_player):
+            yield from [
+                # TODO: FlightType.LOGISTICS
+                # TODO: FlightType.TROOP_TRANSPORT
+            ]
+        else:
+            yield FlightType.STRIKE
+        yield from super().mission_types(for_player)
 
 
 class BuildingGroundObject(TheaterGroundObject):
@@ -240,6 +253,12 @@ class SamGroundObject(BaseDefenseGroundObject):
         else:
             return super().group_name
 
+    def mission_types(self, for_player: bool) -> Iterator[FlightType]:
+        from gen.flights.flight import FlightType
+        if not self.is_friendly(for_player):
+            yield FlightType.DEAD
+        yield from super().mission_types(for_player)
+
 
 class EwrGroundObject(BaseDefenseGroundObject):
     def __init__(self, name: str, group_id: int, position: Point,