From 8c70d1ab791b736e8250c6b1913d3da3f549ec96 Mon Sep 17 00:00:00 2001 From: Dan Albert Date: Wed, 21 Oct 2020 23:53:38 -0700 Subject: [PATCH] Fix foot to meter conversion. Somehow this constant was wrong so all of our foot-to-meter conversions were coming out ~7% too large. We're still introducing some error because we're rounding early rather than only when we need an integer, but it's much more accurate now. --- game/utils.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/game/utils.py b/game/utils.py index 34b82aa4..44652472 100644 --- a/game/utils.py +++ b/game/utils.py @@ -1,14 +1,14 @@ -def meter_to_feet(value_in_meter): +def meter_to_feet(value_in_meter: float) -> int: return int(3.28084 * value_in_meter) -def feet_to_meter(value_in_feet): - return int(float(value_in_feet)/3.048) +def feet_to_meter(value_in_feet: float) -> int: + return int(value_in_feet / 3.28084) -def meter_to_nm(value_in_meter): - return int(float(value_in_meter)*0.000539957) +def meter_to_nm(value_in_meter: float) -> int: + return int(value_in_meter / 1852) -def nm_to_meter(value_in_nm): - return int(float(value_in_nm)*1852) \ No newline at end of file +def nm_to_meter(value_in_nm: float) -> int: + return int(value_in_nm * 1852)