weyne/dcs-retribution
1
0
Fork 0
mirror of https://github.com/dcs-retribution/dcs-retribution.git synced 2025-11-10 15:41:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent empty transfers.

Browse Source 
Disables the 'create transfer order' button in the unit transfer dialog if no units are actually selected for transfer (including when the dialog is first loaded).
This commit is contained in:
bgreman 2021-05-24 23:43:33 -04:00 committed by GitHub
parent d15bfaac76
commit c37a5b2405
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
qt_ui/windows/basemenu/NewUnitTransferDialog.py
View File

@ -4,7 +4,7 @@ import logging
from collections import defaultdict from collections import defaultdict
from typing import Callable, Dict, Type from typing import Callable, Dict, Type
from PySide2.QtCore import Qt from PySide2.QtCore import Qt, Signal
from PySide2.QtWidgets import ( from PySide2.QtWidgets import (
QComboBox, QComboBox,
QDialog, QDialog,
@ -153,6 +153,8 @@ class TransferControls(QGroupBox):
class ScrollingUnitTransferGrid(QFrame): class ScrollingUnitTransferGrid(QFrame):
transfer_quantity_changed = Signal()
def __init__(self, cp: ControlPoint, game_model: GameModel) -> None: def __init__(self, cp: ControlPoint, game_model: GameModel) -> None:
super().__init__() super().__init__()
self.cp = cp self.cp = cp
@ -229,6 +231,7 @@ class ScrollingUnitTransferGrid(QFrame):
origin_inventory -= 1 origin_inventory -= 1
controls.set_quantity(self.transfers[unit_type]) controls.set_quantity(self.transfers[unit_type])
origin_inventory_label.setText(str(origin_inventory)) origin_inventory_label.setText(str(origin_inventory))
self.transfer_quantity_changed.emit()
def decrease(controls: TransferControls): def decrease(controls: TransferControls):
nonlocal origin_inventory nonlocal origin_inventory
@ -240,6 +243,7 @@ class ScrollingUnitTransferGrid(QFrame):
origin_inventory += 1 origin_inventory += 1
controls.set_quantity(self.transfers[unit_type]) controls.set_quantity(self.transfers[unit_type])
origin_inventory_label.setText(str(origin_inventory)) origin_inventory_label.setText(str(origin_inventory))
self.transfer_quantity_changed.emit()
transfer_controls = TransferControls("->", increase, "<-", decrease) transfer_controls = TransferControls("->", increase, "<-", decrease)
@ -276,11 +280,15 @@ class NewUnitTransferDialog(QDialog):
layout.addLayout(self.dest_panel) layout.addLayout(self.dest_panel)
self.transfer_panel = ScrollingUnitTransferGrid(origin, game_model) self.transfer_panel = ScrollingUnitTransferGrid(origin, game_model)
self.transfer_panel.transfer_quantity_changed.connect(
self.on_transfer_quantity_changed
)
layout.addWidget(self.transfer_panel) layout.addWidget(self.transfer_panel)
self.submit_button = QPushButton("Create Transfer Order", parent=self) self.submit_button = QPushButton("Create Transfer Order", parent=self)
self.submit_button.clicked.connect(self.on_submit) self.submit_button.clicked.connect(self.on_submit)
self.submit_button.setProperty("style", "start-button") self.submit_button.setProperty("style", "start-button")
self.submit_button.setDisabled(True)
layout.addWidget(self.submit_button) layout.addWidget(self.submit_button)
def on_submit(self) -> None: def on_submit(self) -> None:
@ -303,3 +311,7 @@ class NewUnitTransferDialog(QDialog):
) )
self.game_model.transfer_model.new_transfer(transfer) self.game_model.transfer_model.new_transfer(transfer)
self.close() self.close()
def on_transfer_quantity_changed(self) -> None:
has_transfer_items = any(self.transfer_panel.transfers.values())
self.submit_button.setDisabled(not has_transfer_items)