Resolves#67
The problem turned out to be split-triggers with no actions, which occurs when a STRIKE flight has no escorts in its package. Added a guard for this so the trigger isn't pushed to the mission in such a case.
This makes sure that aircraft spawning in the air due to a shortage of parking spots, will have the earliest TOT possible. Flights with later TOTs should be generated first so that they remain at the airfield as OCA target.
Resolves#57
"_generate_over_departure" is the method used to generate flights in the air when no more parking spots are available. Pydcs changes were required as it turned out aircraft were trying to spawn on helicopter parking spots, which forces them to start in the air by DCS itself.
Should prevent mid-air collisions in most cases, though I'm still worried about "off map" spawns that can possibly collide, though an easy fix would be to manually use time-spacing.
Alternatively we need to treat it as a special case, assigning different altitudes to avoid collisions during the first leg of the flight if that turns out to be the case...
There doesn't appear to be any reason for us to be poking at
implementation details here aside from changing the name from "unit" to
"building" for that case. Just iterate over the known strike targets.
Making this change uncovered some latent type errors.
Fixes https://github.com/dcs-liberation/dcs_liberation/issues/2564.
Cleanup and reword refuel waypoints
- rename Stopover back to CargoStop
- precise some waypoint naming
Cleanup and refine airlift and airassault waypoints
- Drop Off and Pickup now correctly worded
- Helo waypoints now represent LandingZones for pickup and dropoff
Forbid planes from air assault.
Make air assault drop-off non-optional.
There is always a drop-off location for troops.
Add docs explaining what the assault area is.
Add error handling for cargo drop waypoints.
Document some airlift waypoint behavior.
Remove unnecessary refuel waypoint in airlifts.
Remove CTLD logic from Airlift flightplan for AI
Add Ingress Point to AirAssault FlightPlan
Add simulation halt at AirAssault ingress
Remove AirAssault completly from AutoPlanner
Remove unneeded LandRefuel from Airlift
Clarify cargo waypoints for AirLift and AirAssault
