From ac6810623fa49a3210a6a9f7f72c797bfd05b11e Mon Sep 17 00:00:00 2001 From: MetalStormGhost <89945461+MetalStormGhost@users.noreply.github.com> Date: Sat, 23 Jul 2022 13:49:52 +0300 Subject: [PATCH] Updated Developer's Guide (markdown) --- Developer's-Guide.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Developer's-Guide.md b/Developer's-Guide.md index c128f3a..ac960a3 100644 --- a/Developer's-Guide.md +++ b/Developer's-Guide.md @@ -124,6 +124,8 @@ The type checker is **not** run as part of pre-commit, since that makes it harde Please make a new branch from either develop or master, and make your pull requests to khopa/develop. +We can only merge/revert whole PRs, which means you should try and keep the size of each individual PR as small as possible. Ideally, one PR for one feature/bugfix/change. Also, review latency doesn't scale linearly with review time, and review time doesn't scale linearly with PR complexity. **Smaller PRs will likely get reviewed sooner and faster.** In addition, it's not possible for the testers to isolate bugs on a sub-build level. + New features and bug fixes in pull requests are usually worth mentioning in the changelog. Exceptions are fixes for bugs that never shipped (were only present in a canary build), and changes with no intended user observable behavior, such as a refactor. If you're comfortable writing the note yourself, add it to `changelog.md` in the root of the project in the section for the upcoming release. If you're new to GitHub, https://guides.github.com/introduction/flow/ and the other tutorials on that site may be helpful.