weyne/dcs_liberation
1
0
Fork 0
mirror of https://github.com/dcs-liberation/dcs_liberation.git synced 2025-11-10 14:22:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remember player preferences for plugins.

Browse Source
This commit is contained in:
Dan Albert
2023-04-26 00:13:03 -07:00
parent 081c97583b
commit cf47dd82d7
4 changed files with 56 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
game/settings/settings.py
View File

@@ -499,14 +499,6 @@ class Settings:
if description.remember_player_choice:
settings[name] = self.__dict__[name]
# Plugin settings are currently not handled. It looks like the PluginManager
# probably needs some changes to do so safely. When injecting plugin options
# into Settings with LuaPluginManager.load_settings, it sets a reference to the
# passed Settings object. The lifetime is unclear, but it might be the case that
# canceling the NGW would leave LuaPluginManager in a bad state (yes, we could
# reset it on cancel, but that's just one bug I've thought of and without better
# understanding of how that works it's hard to say where more could be lurking).
with self._player_settings_file.open("w", encoding="utf-8") as settings_file:
yaml.dump(settings, settings_file, sort_keys=False, explicit_start=True)