save pin option on remote menubar

Signed-off-by: fufesou <shuanglongchen@yeah.net>

flutter/lib/desktop/pages/remote_page.dart

@@ -28,14 +28,14 @@ class RemotePage extends StatefulWidget {
   RemotePage({
     Key? key,
     required this.id,
+    required this.menubarState,
   }) : super(key: key);
 
   final String id;
+  final MenubarState menubarState;
   final SimpleWrapper<State<RemotePage>?> _lastState = SimpleWrapper(null);
 
   FFI get ffi => (_lastState.value! as _RemotePageState)._ffi;
-  RxBool get showMenubar =>
-      (_lastState.value! as _RemotePageState)._showMenubar;
 
   @override
   State<RemotePage> createState() {
@@ -50,7 +50,6 @@ class _RemotePageState extends State<RemotePage>
   Timer? _timer;
   String keyboardMode = "legacy";
   final _cursorOverImage = false.obs;
-  final _showMenubar = false.obs;
   late RxBool _showRemoteCursor;
   late RxBool _remoteCursorMoved;
   late RxBool _keyboardEnabled;
@@ -239,7 +238,7 @@ class _RemotePageState extends State<RemotePage>
     paints.add(RemoteMenubar(
       id: widget.id,
       ffi: _ffi,
-      show: _showMenubar,
+      state: widget.menubarState,
       onEnterOrLeaveImageSetter: (func) => _onEnterOrLeaveImage4Menubar = func,
       onEnterOrLeaveImageCleaner: () => _onEnterOrLeaveImage4Menubar = null,
     ));

flutter/lib/desktop/pages/remote_tab_page.dart

@@ -9,6 +9,7 @@ import 'package:flutter_hbb/common/shared_state.dart';
 import 'package:flutter_hbb/consts.dart';
 import 'package:flutter_hbb/models/state_model.dart';
 import 'package:flutter_hbb/desktop/pages/remote_page.dart';
+import 'package:flutter_hbb/desktop/widgets/remote_menubar.dart';
 import 'package:flutter_hbb/desktop/widgets/tabbar_widget.dart';
 import 'package:flutter_hbb/desktop/widgets/material_mod_popup_menu.dart'
     as mod_menu;
@@ -43,9 +44,12 @@ class _ConnectionTabPageState extends State<ConnectionTabPage> {
   static const IconData selectedIcon = Icons.desktop_windows_sharp;
   static const IconData unselectedIcon = Icons.desktop_windows_outlined;
 
+  late MenubarState _menubarState;
+
   var connectionMap = RxList<Widget>.empty(growable: true);
 
   _ConnectionTabPageState(Map<String, dynamic> params) {
+    _menubarState = MenubarState();
     RemoteCountState.init();
     final peerId = params['id'];
     if (peerId != null) {
@@ -59,6 +63,7 @@ class _ConnectionTabPageState extends State<ConnectionTabPage> {
         page: RemotePage(
           key: ValueKey(peerId),
           id: peerId,
+          menubarState: _menubarState,
         ),
       ));
       _update_remote_count();
@@ -88,7 +93,11 @@ class _ConnectionTabPageState extends State<ConnectionTabPage> {
           selectedIcon: selectedIcon,
           unselectedIcon: unselectedIcon,
           onTabCloseButton: () => tabController.closeBy(id),
-          page: RemotePage(key: ValueKey(id), id: id),
+          page: RemotePage(
+            key: ValueKey(id),
+            id: id,
+            menubarState: _menubarState,
+          ),
         ));
       } else if (call.method == "onDestroy") {
         tabController.clear();
@@ -99,6 +108,12 @@ class _ConnectionTabPageState extends State<ConnectionTabPage> {
     });
   }
 
+  @override
+  void dispose() {
+    super.dispose();
+    _menubarState.save();
+  }
+
   @override
   Widget build(BuildContext context) {
     final tabWidget = Container(
@@ -177,7 +192,7 @@ class _ConnectionTabPageState extends State<ConnectionTabPage> {
           );
   }
 
-  // to-do: some dup code to ../widgets/remote_menubar
+  // Note: Some dup code to ../widgets/remote_menubar
   Widget _tabMenuBuilder(String key, CancelFunc cancelFunc) {
     final List<MenuEntryBase<String>> menu = [];
     const EdgeInsets padding = EdgeInsets.only(left: 8.0, right: 5.0);
@@ -187,7 +202,6 @@ class _ConnectionTabPageState extends State<ConnectionTabPage> {
     final ffi = remotePage.ffi;
     final pi = ffi.ffiModel.pi;
     final perms = ffi.ffiModel.permissions;
-    final showMenuBar = remotePage.showMenubar;
     menu.addAll([
       MenuEntryButton<String>(
         childBuilder: (TextStyle? style) => Text(
@@ -202,11 +216,12 @@ class _ConnectionTabPageState extends State<ConnectionTabPage> {
       ),
       MenuEntryButton<String>(
         childBuilder: (TextStyle? style) => Obx(() => Text(
-              translate(showMenuBar.isTrue ? 'Hide Menubar' : 'Show Menubar'),
+              translate(
+                  _menubarState.show.isTrue ? 'Hide Menubar' : 'Show Menubar'),
               style: style,
             )),
         proc: () {
-          showMenuBar.value = !showMenuBar.value;
+          _menubarState.switchShow();
           cancelFunc();
         },
         padding: padding,