Merge pull request #6229 from 21pages/444

yuv 444

flutter/lib/common/widgets/overlay.dart

@@ -27,45 +27,44 @@ class DraggableChatWindow extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
     return isIOS
-    ? IOSDraggable (
-      position: position,
-      chatModel: chatModel,
-      width: width,
-      height: height,
-      builder: (context) {
-    return Column(
-      children: [
-        _buildMobileAppBar(context),
-        Expanded(
-          child: ChatPage(chatModel: chatModel),
-              ),
-            ],
-          );
-        },
-      )
-    : Draggable(
-        checkKeyboard: true,
-        position: position,
-        width: width,
-        height: height,
-        chatModel: chatModel,
-        builder: (context, onPanUpdate) {
-          final child = 
-              Scaffold(
-                  resizeToAvoidBottomInset: false,
-                  appBar: CustomAppBar(
-                    onPanUpdate: onPanUpdate,
-                    appBar: isDesktop
-                        ? _buildDesktopAppBar(context)
-                        : _buildMobileAppBar(context),
+        ? IOSDraggable(
+            position: position,
+            chatModel: chatModel,
+            width: width,
+            height: height,
+            builder: (context) {
+              return Column(
+                children: [
+                  _buildMobileAppBar(context),
+                  Expanded(
+                    child: ChatPage(chatModel: chatModel),
                   ),
-                  body: ChatPage(chatModel: chatModel),
-                );
-          return Container(
-              decoration:
-                  BoxDecoration(border: Border.all(color: MyTheme.border)),
-              child: child);
-        });
+                ],
+              );
+            },
+          )
+        : Draggable(
+            checkKeyboard: true,
+            position: position,
+            width: width,
+            height: height,
+            chatModel: chatModel,
+            builder: (context, onPanUpdate) {
+              final child = Scaffold(
+                resizeToAvoidBottomInset: false,
+                appBar: CustomAppBar(
+                  onPanUpdate: onPanUpdate,
+                  appBar: isDesktop
+                      ? _buildDesktopAppBar(context)
+                      : _buildMobileAppBar(context),
+                ),
+                body: ChatPage(chatModel: chatModel),
+              );
+              return Container(
+                  decoration:
+                      BoxDecoration(border: Border.all(color: MyTheme.border)),
+                  child: child);
+            });
   }
 
   Widget _buildMobileAppBar(BuildContext context) {
@@ -354,14 +353,14 @@ class _DraggableState extends State<Draggable> {
 }
 
 class IOSDraggable extends StatefulWidget {
-  const IOSDraggable({
-    Key? key,
-    this.position = Offset.zero,
-    this.chatModel,
-    required this.width,
-    required this.height,
-    required this.builder})
-    : super(key: key);
+  const IOSDraggable(
+      {Key? key,
+      this.position = Offset.zero,
+      this.chatModel,
+      required this.width,
+      required this.height,
+      required this.builder})
+      : super(key: key);
 
   final Offset position;
   final ChatModel? chatModel;
@@ -423,7 +422,7 @@ class _IOSDraggableState extends State<IOSDraggable> {
     _lastBottomHeight = bottomHeight;
   }
 
-@override
+  @override
   Widget build(BuildContext context) {
     checkKeyboard();
     return Stack(
@@ -439,12 +438,12 @@ class _IOSDraggableState extends State<IOSDraggable> {
               _chatModel?.setChatWindowPosition(_position);
             },
             child: Material(
-              child:
-            Container(
-              width: _width,
-              height: _height,
-              decoration: BoxDecoration(border: Border.all(color: MyTheme.border)),
-              child: widget.builder(context),
+              child: Container(
+                width: _width,
+                height: _height,
+                decoration:
+                    BoxDecoration(border: Border.all(color: MyTheme.border)),
+                child: widget.builder(context),
               ),
             ),
           ),
@@ -499,6 +498,7 @@ class QualityMonitor extends StatelessWidget {
                           "${qualityMonitorModel.data.targetBitrate ?? '-'}kb"),
                       _row(
                           "Codec", qualityMonitorModel.data.codecFormat ?? '-'),
+                      _row("Chroma", qualityMonitorModel.data.chroma ?? '-'),
                     ],
                   ),
                 )

flutter/lib/common/widgets/toolbar.dart

@@ -547,5 +547,22 @@ Future<List<TToggleMenu>> toolbarDisplayToggle(
         child: Text(translate('Use all my displays for the remote session'))));
   }
 
+  // 444
+  final codec_format = ffi.qualityMonitorModel.data.codecFormat;
+  if (versionCmp(pi.version, "1.2.4") >= 0 &&
+      (codec_format == "AV1" || codec_format == "VP9")) {
+    final option = 'i444';
+    final value =
+        bind.sessionGetToggleOptionSync(sessionId: sessionId, arg: option);
+    v.add(TToggleMenu(
+        value: value,
+        onChanged: (value) async {
+          if (value == null) return;
+          await bind.sessionToggleOption(sessionId: sessionId, value: option);
+          bind.sessionChangePreferCodec(sessionId: sessionId);
+        },
+        child: Text(translate('True color(4:4:4)'))));
+  }
+
   return v;
 }

flutter/lib/desktop/pages/desktop_setting_page.dart

@@ -1320,6 +1320,7 @@ class _DisplayState extends State<_Display> {
       otherRow('Lock after session end', 'lock_after_session_end'),
       otherRow('Privacy mode', 'privacy_mode'),
       otherRow('Reverse mouse wheel', 'reverse_mouse_wheel'),
+      otherRow('True color(4:4:4)', 'i444'),
     ];
     if (useTextureRender) {
       children.add(otherRow('Show displays as individual windows',

flutter/lib/mobile/pages/settings_page.dart

@@ -797,6 +797,7 @@ class __DisplayPageState extends State<_DisplayPage> {
             otherRow('Lock after session end', 'lock_after_session_end'),
             otherRow('Privacy mode', 'privacy_mode'),
             otherRow('Touch mode', 'touch-mode'),
+            otherRow('True color(4:4:4)', 'i444'),
           ],
         ),
       ]),

flutter/lib/models/model.dart

@@ -1847,6 +1847,7 @@ class QualityMonitorData {
   String? delay;
   String? targetBitrate;
   String? codecFormat;
+  String? chroma;
 }
 
 class QualityMonitorModel with ChangeNotifier {
@@ -1900,6 +1901,9 @@ class QualityMonitorModel with ChangeNotifier {
       if ((evt['codec_format'] as String).isNotEmpty) {
         _data.codecFormat = evt['codec_format'];
       }
+      if ((evt['chroma'] as String).isNotEmpty) {
+        _data.chroma = evt['chroma'];
+      }
       notifyListeners();
     } catch (e) {
       //